feat(isthmus): add support for scalar subqueries #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Substrait to Calcite mappings to not support scalar subqueries like the follow SQL example:
This PR adds support for mapping scalar subqueries from Substrait into Calcite and adds a test case showing that it works now.
Additionally:
RelCreator
to be created with a list of CREATE SQL statements to initialize the schema of theRelBuilder
RelCreator
to extendSqlConverterBase
so that we can reuse theregisterCreateTables()
methodSubstraitExpressionConverterTest
it gets theExpressionRexConverter
fromSubstraitRelNodeConverter
in order to make sure theExpressionRexConverter
is properly set up to parse sub queries usingSubstraitRelNodeConverter