chore: update to substrait 0.69.0 #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpsilonPrime
approved these changes
Mar 17, 2025
vbarua
reviewed
Mar 18, 2025
| override def visit(expr: Type.PrecisionTime): DataType = { | ||
| Util.assertMicroseconds(expr.precision()) | ||
| TimestampType | ||
| } |
There was a problem hiding this comment.
Two questions:
- From what I'm seeing, Spark doesn't have a direct representation for Time types. Do the semantics of TimestampType match the Substrait expecations for Time? There is no existing mapping for the old
Type.Timeeither. - Assuming 1, does the PrecisionTime type have a timezone? Should this be
TimestampNTZTypeinstead.
There was a problem hiding this comment.
I don't know TBH... I've taken out the mapping entirely so that it will default to throwing an exception (like the old Type.Time).
This can be implemented in the future, once it's better understood. I only intended to do a minimal implementation of this new type in order to fix the build error caused by pulling in the latest substrait library :)
There was a problem hiding this comment.
I've taken out the mapping entirely
That works for me, especially as it wasn't already handled on the deprecated path.
Required to fix the build errors when upgrading to substrait-0.69.0 protos
andrew-coleman
force-pushed
the
substrait-0.69.0
branch
from
8b8513a to
0d7fefb
Compare
vbarua
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to pick up the decimal round() function definition