New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate sorts in aggregate function invocation proto->rel #313

Merged

Blizzara merged 1 commit into substrait-io:main from bvolpato:aggr-sort-fields

Oct 25, 2024

Member

bvolpato commented Oct 25, 2024

When consuming a Substrait proto plan that contains sort within aggregate calls, the SortFields were being dropped in the process.

This is what I mean by sort within aggregates:

SELECT ARRAY_AGG(genre ORDER BY genre) FROM book

So this is a simple addition + test case change that closes that gap.


          fix: propagate sorts in aggregate function invocation proto->rel

1a7359c

Blizzara approved these changes

View reviewed changes

Contributor

Blizzara left a comment

LGTM, thanks @bvolpato!

Blizzara merged commit 75ebac2 into substrait-io:main

13 checks passed

bvolpato deleted the aggr-sort-fields branch

October 25, 2024 15:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet