feat(spark): add MakeDecimal support #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-coleman
force-pushed
the
make_decimal
branch
from
0346df2 to
9938575
Compare
vbarua
changed the title
vbarua
reviewed
Oct 1, 2024
There was a problem hiding this comment.
This seems pretty reasonable overall. There's likely always going to be functions that require some form of special handling. Once we accumulate more we can think about patterns to make it easier to work with them.
I did leave one comment about the matching logic for it though.
| case "make_decimal" => expr.outputType match { | ||
| // Need special case handing of this internal function (not nice, I know). | ||
| // Because the precision and scale arguments are extracted from the output type, | ||
| // we can't use the generic scalar function conversion mechanism here. |
There was a problem hiding this comment.
(not nice, I know)
This seems perfectly reasonable tbh.
| throw new IllegalArgumentException(msg) | ||
| }) | ||
| expr.declaration.name match { | ||
| case "make_decimal" => expr.outputType match { |
There was a problem hiding this comment.
Being pedantic, this should also check the uri of the declaration if it's feasible to avoid applying special handling to an externally defined make_decimal function.
The Spark query optimiser injects an internal function (MakeDecimal) when numeric literals appear in a query. This commit adds support for this, which drastically improves the pass rate for the TPC-DS test suite. Signed-off-by: Andrew Coleman <[email protected]>
andrew-coleman
force-pushed
the
make_decimal
branch
from
9938575 to
3407186
Compare
vbarua
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Spark query optimiser injects an internal function (MakeDecimal) when numeric literals appear in a query. This commit adds support for this, which drastically improves the pass rate for the TPC-DS test suite.