feat(isthmus): cli can now output JSON, TEXT and BINARY proto format #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partial fix for: #211 |
|
Technically text is protobuf text. We are still looking to add the Substrait text format. |
cli can now output PROTOJSON, PROTOTEXT and BINARY proto format
vbarua
force-pushed
the
vbarua/cli-output-format
branch
from
28b8c11 to
60a6afb
Compare
|
@EpsilonPrime good point. What do you think about the names |
|
@vbarua thank you for working on this. |
|
That works for me. The existing implementation can take an explicit format
type and it can also auto detect the type so having some way to eventually
provide auto detect as an option would be nice as well.
…On Wed, Dec 27, 2023, 00:24 Vibhatha Lakmal Abeykoon < ***@***.***> wrote:
@vbarua <https://github.com/vbarua> thank you for working on this.
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABDDCEQHWLGYLRRYJKAZULYLL23NAVCNFSM6AAAAABBCXPF3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGY2DMNZWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
If these changes look reasonable now, I would appreciate an approval when y'all have a chance 🙇 |
EpsilonPrime
approved these changes
Jan 4, 2024
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
cli can now output PROTOJSON, PROTOTEXT and BINARY proto format * ci: update graalVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.