Added support for char_length #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: added tests for string functions
|
|
YannisBres
commented
Dec 15, 2023
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(strings = {"vc32"}) |
There was a problem hiding this comment.
Using the || concatenation operator fails on CHAR columns with "IllegalArgumentException: Unable to convert call ||(char<16>?, char<16>?) at RexExpressionConverter.visitCall(RexExpressionConverter.java:83)".
This should be investigated.
vbarua
reviewed
Dec 15, 2023
|
|
||
| @ParameterizedTest | ||
| @ValueSource(strings = {"c16", "vc32"}) | ||
| void charLength(String column) throws Exception { |
There was a problem hiding this comment.
I made a very small change here: char_length -> charLength
There was a problem hiding this comment.
6 months of *&#@$%! Go and I forgot good ol' Java conventions. What a shame! 😉
vbarua
approved these changes
Dec 15, 2023
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
test: added tests for string functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a string-related scalar function mapping in
FunctionMappingsto support generating plans for queries that use thechar_lengthfunction.It also introduces very basic unit tests for string-related functions, including the newly supported
char_lengthone.