Skip to content

Update xdm.md #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Update xdm.md #39

merged 4 commits into from
Jan 23, 2025

Conversation

dariolina
Copy link
Contributor

A few clarifications based on autonomys/subspace#2815

@dariolina dariolina requested a review from vedhavyas June 4, 2024 10:37
Copy link
Contributor

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits but LGTM

@@ -286,18 +287,18 @@ Before sending any messages, domain needs to have an channel open with the `dst_

### Close Channel

Any domain of either end of the open channel can close the channel:
Any domain of either end of an `Open` or `Initiated` channel can close the channel:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not done yet but will be handled in next PR. Currently just Open channels can be closed. FYI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. The spec is prescriptive here of what should be happenning.

@dariolina dariolina requested a review from vedhavyas June 5, 2024 10:41
@dariolina dariolina merged commit f7f3766 into main Jan 23, 2025
@dariolina dariolina deleted the xdm-corrections branch January 23, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants