Skip to content

Commit

Permalink
Remove TODO in .../kubeproxy/endpoint_handler.go
Browse files Browse the repository at this point in the history
"Handle a remote endpoint removal use-case
  - remove related iptable rules"

This is already handled by line:

kp.updateIptableRulesForInterClusterTraffic(endpoint.Spec.Subnets,
    Delete)

Signed-off-by: Tom Pantelis <[email protected]>
  • Loading branch information
tpantelis authored and aswinsuryan committed Jul 26, 2024
1 parent 1d57fdb commit 24c8b0d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/routeagent_driver/handlers/kubeproxy/endpoint_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ func (kp *SyncHandler) RemoteEndpointRemoved(endpoint *submV1.Endpoint) error {
kp.remoteSubnets.Delete(inputCidrBlock)
delete(kp.remoteSubnetGw, inputCidrBlock)
}
// TODO: Handle a remote endpoint removal use-case
// - remove related iptable rules

if err := kp.updateRoutingRulesForInterClusterSupport(endpoint.Spec.Subnets, Delete); err != nil {
logger.Errorf(err, "updateRoutingRulesForInterClusterSupport for removed remote %#v returned error",
endpoint)
Expand Down

0 comments on commit 24c8b0d

Please sign in to comment.