Migrate to ECMAScript module #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source files have already been `.mjs` and ESM-compatible. This change should not affect the runtime behavior.
ybiquitous
commented
Dec 3, 2025
| @@ -1,8 +1,7 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "ES2019", | |||
Member
Author
There was a problem hiding this comment.
[note] If module is NodeNext, then target is set to ESNext by default.
ybiquitous
commented
Dec 3, 2025
| "module": "commonjs", | ||
| "lib": ["ES2019"], | ||
| "module": "NodeNext", | ||
| "lib": ["ESNext"], |
Member
Author
There was a problem hiding this comment.
[note] As long as there are no problems, we should keep ESNext, regardless of supported Node.js versions.
Ref:
Lines 78 to 80 in 64aa196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None.
The source files have already been
.mjsand ESM-compatible. This change should not affect the runtime behavior.