Skip to content

feat: add registry config#20

Merged
matteojug-stacks merged 2 commits intomainfrom
feat/add-registry-config
Apr 16, 2026
Merged

feat: add registry config#20
matteojug-stacks merged 2 commits intomainfrom
feat/add-registry-config

Conversation

@matteojug-stacks
Copy link
Copy Markdown
Contributor

Add smart contract registry in spox config.

Testing information

Add some unit tests on the parsing, the whole flow was also tested locally with spox registry aware + front end (coming soon™)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for configuring an optional Stacks smart-contract registry in the spox configuration, including parsing and validation.

Changes:

  • Add registry_contract (optional QualifiedContractIdentifier) to Settings with a custom deserializer.
  • Add validation + new SpoxConfigError variant to require stacks config when registry_contract is set.
  • Extend default config documentation and add unit tests for parsing the registry contract.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/config/serialization.rs Adds contract_deserializer_option to parse optional qualified contract IDs.
src/config/mod.rs Extends Settings with registry_contract, adds validation, and adds parsing tests.
src/config/error.rs Introduces MissingStacksConfig validation error.
src/config/default.toml Documents the new registry_contract config/env var.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/config/mod.rs
Comment thread src/config/mod.rs
Comment thread src/config/serialization.rs
Copy link
Copy Markdown

@djordon-stacks djordon-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@matteojug-stacks matteojug-stacks added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 3a73379 Apr 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants