Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for configuring an optional Stacks smart-contract registry in the spox configuration, including parsing and validation.
Changes:
- Add
registry_contract(optionalQualifiedContractIdentifier) toSettingswith a custom deserializer. - Add validation + new
SpoxConfigErrorvariant to requirestacksconfig whenregistry_contractis set. - Extend default config documentation and add unit tests for parsing the registry contract.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/config/serialization.rs |
Adds contract_deserializer_option to parse optional qualified contract IDs. |
src/config/mod.rs |
Extends Settings with registry_contract, adds validation, and adds parsing tests. |
src/config/error.rs |
Introduces MissingStacksConfig validation error. |
src/config/default.toml |
Documents the new registry_contract config/env var. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add smart contract registry in spox config.
Testing information
Add some unit tests on the parsing, the whole flow was also tested locally with spox registry aware + front end (coming soon™)