Allow non-command/event files to be put in the same dir#104
Open
HarryAllen1 wants to merge 1 commit intostuyy:masterfrom
HarryAllen1:patch-1
Open
Allow non-command/event files to be put in the same dir#104HarryAllen1 wants to merge 1 commit intostuyy:masterfrom HarryAllen1:patch-1
HarryAllen1 wants to merge 1 commit intostuyy:masterfrom
HarryAllen1:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow helper ts and js files to be put in the same directory as the event and command files without the "... is not a constructor".
In other words, it allows this file structure to work:
This will require command and event files to end in
Command.tsandEvent.tsrespectively, which slappey already does.