Add support for handling 'tmap' items #1503
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ram-mohan
force-pushed
the
master
branch
2 times, most recently
from
dce9a85 to
7440574
Compare
farindk
reviewed
Apr 7, 2025
libheif/context.h
Outdated
| std::shared_ptr<ImageItem> get_primary_image(bool return_error_image); | ||
|
|
||
| #if WITH_EXPERIMENTAL_GAIN_MAP | ||
| std::shared_ptr<ImageItem> get_gain_map_image() { return m_gain_map_image; } |
There was a problem hiding this comment.
This only works if there is only a single gain map in the file. The gain map should probably be stored in the ImageItem like the alpha image or the depth map.
There was a problem hiding this comment.
Thank you for the review, As indicated, i have moved the gainmap info inside ImageItem
farindk
reviewed
Apr 7, 2025
libheif/context.h
Outdated
| #if WITH_EXPERIMENTAL_GAIN_MAP | ||
| std::shared_ptr<ImageItem> get_gain_map_image() { return m_gain_map_image; } | ||
|
|
||
| std::shared_ptr<ImageMetadata> get_gain_map_metadata(); |
There was a problem hiding this comment.
Same here, the gain map metadata has to be part of ImageItem to work correctly when there are several images in a file.
|
Thank you. Note that there is also some work for this in #1121. I will have a closer look at this when we switched to the v1.20.x branch and can do API additions. |
Gain map technology offers a way to create an image (henceforth referred as derived image) from one base input image and a secondary input image called as a gainmap input image. Reconstruction is done by applying the gain map to the base image according to iso 21496-1 section 6. This change provides API to read, write base input image, gain map input image, gain map metadata. Third party applications can make use of this API to render only base image or reconstruct the derived image and render the same. By default these API is disabled and can be enabled at configure time using option -DWITH_EXPERIMENTAL_GAIN_MAP=1 TODO: add plugins for encoding, decoding uhdr images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gain map technology offers a way to create an image (henceforth referred
as derived image) from one base input image and a secondary input image
called as a gainmap input image. Reconstruction is done by applying the
gain map to the base image according to iso 21496-1 section 6.
This change provides API to read, write base input image, gain map input
image, gain map metadata. Third party applications can make use of this
API to render only base image or reconstruct the derived image and
render the same.
By default these API is disabled and can be enabled at configure time
using option -DWITH_EXPERIMENTAL_GAIN_MAP=1
TODO: add plugins for encoding, decoding uhdr images