Add proxy container configuration #44
Conversation
A proxy container (i.e. Toxiproxy) can be optionally configured. This container allows to create a TCP proxy between test code and Kafka broker. Every Kafka broker request will pass through the proxy where you can simulate network conditions (i.e. connection cut, latency). For example, you can create a network partition when running a multi-node cluster. This commit also adds a common super-interface for containers. Signed-off-by: Federico Valeri <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
There was a problem hiding this comment.
Maybe you can add to the description some more explanation as to how your changes related to the aim of the PR and why are they needed for the proxy support since it is not really clear to me how some of your changes relate to it.
It would be also good to explain how does the proxy impact the advertised hosts in Kafka since that is not clear either.
.checkstyle/checkstyle.xml
Outdated
| <module name="ClassDataAbstractionCoupling"> | ||
| <!-- default is 7 --> | ||
| <property name="max" value="10"/> | ||
| </module> |
There was a problem hiding this comment.
Please use annotation rather than increasing the global limit.
There was a problem hiding this comment.
Right, I forgot to add the implementation details.
I think it is better to also add them at the javadoc level.
Signed-off-by: Federico Valeri <[email protected]>
The abstraction is not strictly needed for this PR, but I think it's useful to have a common interface when dealing with tests using both single and multi-node deployments, as it doesn't force you to use |
Signed-off-by: Federico Valeri <[email protected]>
There was a problem hiding this comment.
The abstraction is not strictly needed for this PR, but I think it's useful to have a common interface when dealing with tests using both single and multi-node deployments, as it doesn't force you to use Startable. This is also something that was requested before.
I guess ideally it should have a separate PR then ;-)
A proxy container (i.e. Toxiproxy) can be optionally configured. This container allows to create a TCP proxy between test code and Kafka broker.
Every Kafka broker request will pass through the proxy where you can simulate network conditions (i.e. connection cut, latency). For example, you can create a network partition when running a multi-node cluster.
How it works?
The
StrimziKafkaContainerclass usesgetBootstrapServers()to build theKAFKA_ADVERTISED_LISTENERSconfiguration. WhenproxyContaineris configured, the bootstrap URL returned bygetBootstrapServers()contains the proxy host and port. For this reason, Kafka clients will always pass through the proxy, even after refreshing cluster metadata.Additional info
This commit also adds a common super-interface for containers.
I changed the project version only because it doesn't seem to be in sync with releases.