Capture Frame Feature - #1
Conversation
| } | ||
|
|
||
| - (void)captureLocalFrame:()string { | ||
| if (self.camera) { |
There was a problem hiding this comment.
Nit: Might be best to fail early instead of nesting this block of code.
if (!self.camera) {
return;
}
|
Running into errors trying to run the example app. I don't think its related to this code though. Just a haste module naming collision. Will see if I can get past it. |
| } | ||
|
|
||
| // Start the capture session | ||
| [captureSession startRunning]; |
There was a problem hiding this comment.
Will this work even though the camera is already being used for video capture?
There was a problem hiding this comment.
I do not know, I didn't get far enough to start testing it.
There was a problem hiding this comment.
@joshdhenry I saw you approved this PR. Were you able to get the example app running and test it out?
| } | ||
|
|
||
| private void captureFrame(Promise promise) { | ||
| cameraCapturer.onFrameCaptured(VideoFrame frame); |
There was a problem hiding this comment.
This code doesn't look like it would compile
There was a problem hiding this comment.
That is quite likely, I was early in piecing together code from various sources when I switched to working on the web implementation.
3 participants
No description provided.