Allow full range of log levels #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teabot
requested review from
merlimat,
nahguam and
andrasbeni
as code owners
andrasbeni
reviewed
Dec 12, 2022
Co-authored-by: Andras Beni <[email protected]>
Co-authored-by: Andras Beni <[email protected]>
|
Thanks for the review @andrasbeni — applied your suggestions. |
andrasbeni
approved these changes
Dec 12, 2022
nahguam
approved these changes
Dec 12, 2022
merlimat
approved these changes
Dec 12, 2022
| Use: "oxia", | ||
| Short: "Short description", | ||
| Long: `Long description`, | ||
| PreRunE: configureLogLevel, |
There was a problem hiding this comment.
We could also call the common.ConfigureLogger() from this hook
| // LogDebug Used for flags | ||
| LogDebug bool | ||
| // LogLevel Used for flags | ||
| LogLevel zerolog.Level |
There was a problem hiding this comment.
(for a different PR) Should we also improve the LogJson argument to make it a kind of --log-format json|text|.... ?
Co-authored-by: Dave Maughan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes info and debug is not enough.
Changes
-dflag from CLI-lflag to permit usage of any one of the rs/zerolog levelsinfoas before