Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vertical audio exclusion #623

Merged
merged 5 commits into from
Feb 20, 2025
Merged

fix vertical audio exclusion #623

merged 5 commits into from
Feb 20, 2025

Conversation

summeroff
Copy link

@summeroff summeroff commented Feb 19, 2025

Description

Fix processing of audio for global sources what does not have scene item to control if they should go to specific output.
Include small code cleanup and debug log removal.

Motivation and Context

Global audio sources does not processed in same way as scene items. And was missing from initial implementation.

How Has This Been Tested?

Test builds of libobs/osn was made to test if sound goes to all destinations.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the streamlabs branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link

@mhoyer-streamlabs mhoyer-streamlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@summeroff summeroff merged commit c1cb23e into streamlabs Feb 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants