-
-
Notifications
You must be signed in to change notification settings - Fork 598
Change StrawberryConfig to be a dictionary instead of a class #4039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideTransition schema configuration to a dictionary-based API by introducing a TypedDict, deprecating the StrawberryConfig class, adding normalization logic, refactoring internal accesses, and updating documentation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Apollo Federation Subgraph Compatibility Results
Learn more: |
035c8a9 to
3823b9c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4039 +/- ##
==========================================
- Coverage 94.39% 94.29% -0.10%
==========================================
Files 534 535 +1
Lines 34834 34878 +44
Branches 1831 1839 +8
==========================================
+ Hits 32881 32889 +8
- Misses 1657 1691 +34
- Partials 296 298 +2 🚀 New features to boost your workflow:
|
f22d944 to
a0a908b
Compare
CodSpeed Performance ReportMerging #4039 will not alter performanceComparing Summary
|
a0a908b to
aba9676
Compare
StrawberryConfig class
I wanted to make it backwards compatibile, but not fully sure it is worth it, since the user changes should be pretty small