Allow for numeric escape sequences #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lua strings accept numerical escapes as a "\ddd" sequence, where ddd is 1-3 decimal digits (see Lua Manual, "Lexical Conventions"). This patch makes the parser tolerate escape sequences starting with a digit, copying them to the output as-is. Note that they're not validated in this case.
|
This (partly) fixes #4. Lua 5.2+ also recognizes Regards, NiteHawk |
"esc" isn't reused, so there is no need for a local variable. The second test thus essentially is if not CharacterForEscape[c3] then ... And we also don't need to string.match() for digits on c3 when we have the Digits[c3] table lookup readily available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lua strings accept numerical escapes as a "\ddd" sequence, where
ddd is 1-3 decimal digits (see Lua Manual, "Lexical Conventions").
This patch makes the parser tolerate escape sequences starting
with a digit, copying them to the output as-is.
Note that they're not validated in this case.