refactor(main): _resolve_model_id_from_config nimmt PrinterYAMLConfig statt Any (#67)#123
Conversation
… statt Any (#67) Audit #67 / PR #59 Finding: `printer_cfg: Any` in `_resolve_model_id_from_config` verletzt die mypy-strict-policy. Der tatsächliche Typ ist `PrinterYAMLConfig` (aus `app.schemas.printer_config`), wird vom `PrinterConfigLoader.all()` zurückgegeben und im Caller schon typkorrekt iteriert. Fix: Import + Annotation. Verhalten 1:1. mypy ✓ ruff ✓ tests grün (test_lifespan.py 7 passed). Refs #67 Audit-Punkt: "PR #59 — main.py:112,119 _build_backend Any typed" (Die `_build_backend`-Funktion existiert nicht mehr nach Phase 1k.1a; das verbliebene `Any` war in `_resolve_model_id_from_config`.) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! Diese Änderung refaktoriert die Funktion _resolve_model_id_from_config, um eine explizite Typisierung anstelle von Any zu verwenden. Dies erhöht die Robustheit des Codes und stellt sicher, dass die übergebene Konfiguration korrekt validiert wird, was einen weiteren Punkt aus dem Sicherheits-Audit adressiert. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves type safety in backend/app/main.py by replacing the Any type annotation for the printer_cfg parameter in _resolve_model_id_from_config with the specific PrinterYAMLConfig schema. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 89.27% 89.30% +0.02%
==========================================
Files 91 91
Lines 4262 4263 +1
Branches 368 368
==========================================
+ Hits 3805 3807 +2
Misses 359 359
+ Partials 98 97 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
## <small>0.10.2 (2026-06-15)</small> * refactor(main): _resolve_model_id_from_config nimmt PrinterYAMLConfig statt Any (#67) (#123) ([2ff51d2](2ff51d2)), closes [#67](#67) [#123](#123) [#67](#67) [#59](#59) [#67](#67) [#59](#59) * refactor(snipeit): typisiere response payload als TypedDict statt dict[str, Any] (#67) (#122) ([e88601b](e88601b)), closes [#67](#67) [#122](#122) [#67](#67) [#67](#67) [#51](#51) * perf(lifespan): plugin-discovery in Thread auslagern (Audit #67) (#121) ([48215b4](48215b4)), closes [#67](#67) [#121](#121) [#67](#67) [#59](#59) * fix(config): stricter validation for log_level + webhook_api_key (#46) (#116) ([6b8ac30](6b8ac30)), closes [#46](#46) [#116](#116) [#46](#46) [#46](#46) [#46](#46) [#46](#46) [#116](#116) * fix(print): copies-replication erzeugt UNIQUE job_ids (Round 2 #hangar-109) (#120) ([bd781ae](bd781ae)), closes [#hangar-109](https://github.com/strausmann/label-printer-hub/issues/hangar-109) [#120](#120) [#115](#115) * fix(print): PrintOptions.copies replicates images for hardware print (#hangar-109) (#115) ([d27bbcc](d27bbcc)), closes [#hangar-109](https://github.com/strausmann/label-printer-hub/issues/hangar-109) [#115](#115) [strausmann/hangar#109](https://github.com/strausmann/hangar/issues/109) * docs(metrics): präzisiere sse_events_published_total Beschreibung (Audit #67) (#119) ([ab8c4c4](ab8c4c4)), closes [#67](#67) [#119](#119) [#67](#67) [#67](#67) [#65](#65) * docs(ptouch): korrigiere Tape-Klassen-Namen in ptouch-integration.md (Audit #67) (#118) ([0faab99](0faab99)), closes [#67](#67) [#118](#118) [#67](#67) [#59](#59) * chore(readme): codecov badge ohne embedded Token (Audit #67) (#117) ([4bb5423](4bb5423)), closes [#67](#67) [#117](#117) [#67](#67) [#59](#59) [skip ci]
Summary
Letzter verbleibender
Any-typed Parameter aus dem Audit-#67-Finding zu_build_backend/factory:_resolve_model_id_from_config(printer_cfg: Any)→PrinterYAMLConfig. Der_build_backend-Helper existiert nicht mehr nach Phase 1k.1a —_resolve_model_id_from_configwar das einzige verbliebeneAnyin dem Bereich.Test plan
tests/unit/test_lifespan.py— 7 passedRefs #67 Audit-Punkt:
PR #59 — main.py:112,119 _build_backend Any typed