Skip to content

refactor(main): _resolve_model_id_from_config nimmt PrinterYAMLConfig statt Any (#67)#123

Merged
strausmann merged 1 commit into
mainfrom
fix/typed-resolve-model-id
Jun 14, 2026
Merged

refactor(main): _resolve_model_id_from_config nimmt PrinterYAMLConfig statt Any (#67)#123
strausmann merged 1 commit into
mainfrom
fix/typed-resolve-model-id

Conversation

@strausmann

Copy link
Copy Markdown
Owner

Summary

Letzter verbleibender Any-typed Parameter aus dem Audit-#67-Finding zu _build_backend/factory: _resolve_model_id_from_config(printer_cfg: Any)PrinterYAMLConfig. Der _build_backend-Helper existiert nicht mehr nach Phase 1k.1a — _resolve_model_id_from_config war das einzige verbliebene Any in dem Bereich.

Test plan

  • mypy ✓ ruff ✓
  • tests/unit/test_lifespan.py — 7 passed

Refs #67 Audit-Punkt: PR #59 — main.py:112,119 _build_backend Any typed

… statt Any (#67)

Audit #67 / PR #59 Finding: `printer_cfg: Any` in
`_resolve_model_id_from_config` verletzt die mypy-strict-policy. Der
tatsächliche Typ ist `PrinterYAMLConfig` (aus
`app.schemas.printer_config`), wird vom `PrinterConfigLoader.all()`
zurückgegeben und im Caller schon typkorrekt iteriert.

Fix: Import + Annotation. Verhalten 1:1.

mypy ✓ ruff ✓ tests grün (test_lifespan.py 7 passed).

Refs #67 Audit-Punkt: "PR #59 — main.py:112,119 _build_backend Any typed"
(Die `_build_backend`-Funktion existiert nicht mehr nach Phase 1k.1a; das
verbliebene `Any` war in `_resolve_model_id_from_config`.)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 14, 2026 15:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Diese Änderung refaktoriert die Funktion _resolve_model_id_from_config, um eine explizite Typisierung anstelle von Any zu verwenden. Dies erhöht die Robustheit des Codes und stellt sicher, dass die übergebene Konfiguration korrekt validiert wird, was einen weiteren Punkt aus dem Sicherheits-Audit adressiert.

Highlights

  • Verbesserte Typsicherheit: Der Parameter printer_cfg in der Funktion _resolve_model_id_from_config wurde von Any auf den spezifischen Typ PrinterYAMLConfig umgestellt.
  • Abschluss des Audit-Findings: Mit dieser Änderung wurde der letzte verbleibende Any-Typ in diesem Bereich entfernt, wie im Audit-Finding Audit: 41 unaddressed review findings across PRs #50-#65 #67 gefordert.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@strausmann
strausmann merged commit 2ff51d2 into main Jun 14, 2026
13 checks passed
@strausmann
strausmann deleted the fix/typed-resolve-model-id branch June 14, 2026 15:04

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves type safety in backend/app/main.py by replacing the Any type annotation for the printer_cfg parameter in _resolve_model_id_from_config with the specific PrinterYAMLConfig schema. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.30%. Comparing base (e88601b) to head (4e06429).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   89.27%   89.30%   +0.02%     
==========================================
  Files          91       91              
  Lines        4262     4263       +1     
  Branches      368      368              
==========================================
+ Hits         3805     3807       +2     
  Misses        359      359              
+ Partials       98       97       -1     
Components Coverage Δ
Printer Backends (transport) 86.87% <ø> (ø)
Printer Models (drivers) 88.20% <ø> (ø)
Services 91.20% <ø> (ø)
REST API 84.97% <ø> (ø)
Pydantic Schemas 100.00% <ø> (ø)
Integration Plugins 100.00% <ø> (ø)
Files with missing lines Coverage Δ
backend/app/main.py 86.55% <100.00%> (+0.39%) ⬆️
Flag Coverage Δ
backend 89.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88601b...4e06429. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions Bot pushed a commit that referenced this pull request Jun 15, 2026
## <small>0.10.2 (2026-06-15)</small>

* refactor(main): _resolve_model_id_from_config nimmt PrinterYAMLConfig statt Any (#67) (#123) ([2ff51d2](2ff51d2)), closes [#67](#67) [#123](#123) [#67](#67) [#59](#59) [#67](#67) [#59](#59)
* refactor(snipeit): typisiere response payload als TypedDict statt dict[str, Any] (#67) (#122) ([e88601b](e88601b)), closes [#67](#67) [#122](#122) [#67](#67) [#67](#67) [#51](#51)
* perf(lifespan): plugin-discovery in Thread auslagern (Audit #67) (#121) ([48215b4](48215b4)), closes [#67](#67) [#121](#121) [#67](#67) [#59](#59)
* fix(config): stricter validation for log_level + webhook_api_key (#46) (#116) ([6b8ac30](6b8ac30)), closes [#46](#46) [#116](#116) [#46](#46) [#46](#46) [#46](#46) [#46](#46) [#116](#116)
* fix(print): copies-replication erzeugt UNIQUE job_ids (Round 2 #hangar-109) (#120) ([bd781ae](bd781ae)), closes [#hangar-109](https://github.com/strausmann/label-printer-hub/issues/hangar-109) [#120](#120) [#115](#115)
* fix(print): PrintOptions.copies replicates images for hardware print (#hangar-109) (#115) ([d27bbcc](d27bbcc)), closes [#hangar-109](https://github.com/strausmann/label-printer-hub/issues/hangar-109) [#115](#115) [strausmann/hangar#109](https://github.com/strausmann/hangar/issues/109)
* docs(metrics): präzisiere sse_events_published_total Beschreibung (Audit #67) (#119) ([ab8c4c4](ab8c4c4)), closes [#67](#67) [#119](#119) [#67](#67) [#67](#67) [#65](#65)
* docs(ptouch): korrigiere Tape-Klassen-Namen in ptouch-integration.md (Audit #67) (#118) ([0faab99](0faab99)), closes [#67](#67) [#118](#118) [#67](#67) [#59](#59)
* chore(readme): codecov badge ohne embedded Token (Audit #67) (#117) ([4bb5423](4bb5423)), closes [#67](#67) [#117](#117) [#67](#67) [#59](#59)

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants