docs(metrics): präzisiere sse_events_published_total Beschreibung (Audit #67)

[strausmann]

Summary

Der printer_hub_sse_events_published_total Counter wird im Subscriber-Loop pro publish()-Event pro aktivem Client inkrementiert — also N mal pro publish bei N Clients. Der Metric-Name suggeriert "1 pro publish" — Audit #67 hatte das als irreführend markiert.

Name bleibt wegen Grafana-Dashboard-Kompatibilität. Description + Code-Comment klären die Semantik jetzt:

Total SSE events delivered to subscribers (one increment per subscriber per publish)

Test plan

• Keine Code-Pfad-Änderung — nur Counter-Beschreibung
• /metrics-Endpoint zeigt die neue HELP-Zeile

Refs #67 Audit-Punkt: PR #65 — events.py:208 — sse_events_published_total inflation

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Diese Änderung korrigiert die irreführende Dokumentation des 'sse_events_published_total' Counters. Da der Name aus Gründen der Abwärtskompatibilität mit bestehenden Grafana-Dashboards beibehalten werden muss, wurde die Beschreibung angepasst, um die tatsächliche Zählweise – ein Inkrement pro Subscriber pro Publish – präzise abzubilden.

Highlights

• Präzisierung der Metrik-Beschreibung: Die Beschreibung des 'sse_events_published_total' Counters wurde aktualisiert, um klarzustellen, dass der Zähler pro Subscriber und nicht pro Publish-Event inkrementiert wird.
• Beibehaltung des Metrik-Namens: Der Name der Metrik bleibt unverändert, um die Kompatibilität mit bestehenden Grafana-Dashboards zu gewährleisten.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the description and adds explanatory comments to the sse_events_published_total metric in backend/app/api/routes/events.py to clarify its behavior. The review feedback suggests using standard German umlauts instead of digraphs in the comments to maintain consistency with the rest of the codebase.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Für eine konsistente Schreibweise im gesamten Projekt sollten echte deutsche Umlaute (ö, ü) anstelle von Umlaut-Ersatzzeichen (oe, ue) verwendet werden, da diese auch in anderen Dateien wie config.py (z. B. „gelöscht“, „beschränkt“) standardmäßig genutzt werden.

Suggested change

	# Inkrementiert pro SSE-Subscriber, nicht pro publish()-Call: ein
	# publish() mit N aktiven Clients erhoeht den Counter um N. Der
	# Metric-Name ist aus historischen Gruenden behalten (Grafana-
	# Dashboards) — semantisch ist es "delivered to subscriber",
	# nicht "published once" (siehe Audit #67 Hinweis).
	# Inkrementiert pro SSE-Subscriber, nicht pro publish()-Call: ein
	# publish() mit N aktiven Clients erhöht den Counter um N. Der
	# Metric-Name ist aus historischen Gründen behalten (Grafana-
	# Dashboards) — semantisch ist es "delivered to subscriber",
	# nicht "published once" (siehe Audit #67 Hinweis).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.24%. Comparing base (0faab99) to head (d7e6055).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   89.26%   89.24%   -0.03%     
==========================================
  Files          91       91              
  Lines        4257     4257              
  Branches      369      369              
==========================================
- Hits         3800     3799       -1     
- Misses        359      360       +1     
  Partials       98       98              

Components	Coverage Δ
Printer Backends (transport)	86.87% <ø> (ø)
Printer Models (drivers)	88.20% <ø> (ø)
Services	91.20% <ø> (-0.07%)	⬇️
REST API	84.97% <ø> (ø)
Pydantic Schemas	100.00% <ø> (ø)
Integration Plugins	100.00% <ø> (ø)

Files with missing lines	Coverage Δ
backend/app/api/routes/events.py	82.78% <ø> (ø)

... and 1 file with indirect coverage changes

Flag	Coverage Δ
backend	89.24% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0faab99...d7e6055. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.