Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(examples): compose.pangolin.yml + .env.example — PRINTER_HUB_* prefix, korrekte Pangolin-Labels #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(examples): compose.pangolin.yml + .env.example — PRINTER_HUB_* prefix, korrekte Pangolin-Labels #113
Changes from all commits
26b79e7File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
.env.examplewurdeLOG_LEVELdurchPRINTER_HUB_LOG_LEVELersetzt. Incompose.pangolin.ymlwird für den Frontend-Container jedoch weiterhinLOG_LEVEL=${LOG_LEVEL:-INFO}verwendet. DaLOG_LEVELnun nicht mehr in.env.exampledokumentiert ist, ist für Benutzer nicht direkt ersichtlich, wie sie das Logging des Frontends konfigurieren können. Es wird empfohlen, einen entsprechenden Kommentar oder die VariableLOG_LEVEL=INFOfür das Frontend in.env.examplezu behalten.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Der Kommentar erwähnt, dass zwei Routen auf derselben Domain nur mit unterschiedlichen
path-prefix-Werten möglich sind. Im Code wird jedoch keinpath-prefix-Label auf Ressourcenebene verwendet, sonderntargets[0].pathundtargets[0].path-match. Bitte prüfen Sie, ob der Kommentar veraltet ist oder ob hier tatsächlich ein Label wiepangolin.public-resources.printerhub-webhooks.path-prefix=/api/webhook/auf Ressourcenebene fehlt, damit Pangolin die Routen und den SSO-Bypass korrekt trennen kann.Uh oh!
There was an error while loading. Please reload this page.