Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(1k.1a): Hub Layout-Engine — replaces 21 templates with semantic engine #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(1k.1a): Hub Layout-Engine — replaces 21 templates with semantic engine #109
Changes from 33 commits
61fc7b825454679c877cbb10552ac37d4946a1b88db08c4c26de07cd10984732231bd518ed3ff297258a7915f2f0448586921250512fe7bd05826e9bbd77cc93b9420b3b2a6c2f7f82f6eef85b45f0cb03fb0bfdcf957868e086a78c289457587ac8dd277c1b394c5694fcc25ad1faf111e9b08182c4ed19c4e3bfb24a4473cdaca9ba7c5030f32e8331253163a72b01fb9e44File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Uh oh!
There was an error while loading. Please reload this page.
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
engine.renderandimage.saveoperations are CPU-bound (generating QR codes, rendering text, and compressing PNG bytes). Running them directly in the asyncrender_previewendpoint blocks the event loop, which can severely degrade API performance under concurrent load.Please offload these operations to a worker thread using
asyncio.to_thread.References
asyncio.to_threadwhen calling them from asynchronous FastAPI route handlers to prevent blocking the event loop.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.