make generated service configs update-safe - #234
Merged
Conversation
GitGab19
force-pushed
the
fix-update-errors
branch
from
July 29, 2026 14:17
cf91aa7 to
82c3dd9
Compare
lucasbalieiro
left a comment
lucasbalieiro
left a comment
Collaborator
There was a problem hiding this comment.
concept ACK 82c3dd9
lucasbalieiro
approved these changes
Jul 29, 2026
lucasbalieiro
left a comment
lucasbalieiro
left a comment
Collaborator
There was a problem hiding this comment.
ACK 82c3dd9
I've tried to test this locally by running an older version of sv2-ui (0.5.0 and 0.4.0), configured the wizard to a sovereing solo mining mode and then running again with the changes of this PR (simulating an update of the app) and the transition went well,
Regenerate managed Translator/JDC configs from saved setup before starts and auto-starts, so app updates cannot keep stale TOML files around. If saved setup is valid but missing required choices for the current version, surface a setup review with existing values prefilled. If saved setup cannot be read, preserve it and require an explicit reset. Also add shared validation and a release smoke check for generated configs against the selected sv2-apps images.
Add backoff for repeated auto-start failures, log service-config preparation errors on start paths, and make setup-review recovery resume with saved choices without changing the normal reconfigure flow.
GitGab19
force-pushed
the
fix-update-errors
branch
from
July 29, 2026 19:49
88624ca to
9d781ed
Compare
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR regenerates managed Translator/JDC configs from saved setup before starts and auto-starts, so app updates cannot keep stale TOML files around.
If saved setup is valid but missing required choices for the current version, surface a setup review with existing values prefilled. If saved setup cannot be read, preserve it and require an explicit reset. Also add shared validation and a release smoke check for generated configs against the selected
sv2-appsimages.It unblocks getumbrel/umbrel-apps#5933.
Here a recording of the exact case described in the PR reviewed by the Umbrel team, where a TOML config file is stale, and it gets recovered by using the
state.jsoninformation:Screencast.From.2026-07-29.15-32-15.mp4
Here a recording of the case where the user runs it from an incomplete state:
Screencast.From.2026-07-29.15-33-01.mp4
Here a recording of the case where the user runs it from an invalid
state.json:Screencast.From.2026-07-29.15-34-03.mp4