Refactor advanced mining settings into shared compact form - #226
Merged
pavlenex merged 2 commits intoJul 28, 2026
Conversation
Collaborator
There was a problem hiding this comment.
the field is allowing some "crazy" values that breaks the config file:
translator dies cannot start due to bad config:
Translator proxy config error: Bad `config` TOML deserialize: `invalid type: 64-bit unsigned integer `1000000000000`, expected an unsigned 16 bit integer for key `downstream_extranonce2_size``we probably already had this before, but worth fixing by adding a validation to the Downstream extranonce2 field since we are already touching this area.
Contributor
Author
|
@lucasbalieiro Good one, fixed in ea0872f |
Member
|
Can you solve conflicts @pavlenex? I can do it if you prefer, but there's a chance I'd become the author of your commits after that. |
GitGab19
force-pushed
the
compact-advanced-mining-config
branch
2 times, most recently
from
July 27, 2026 18:44
619aaf3 to
99a8f27
Compare
pavlenex
force-pushed
the
compact-advanced-mining-config
branch
from
July 28, 2026 06:16
99a8f27 to
83bae3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the advanced mining configuration into a shared component used by both the setup wizard and Settings, ensuring the fields, defaults, validation, and descriptions remain consistent. It also introduces a more compact responsive layout by constraining the form width, placing Shares Per Minute and Extranonce2 Size side-by-side on wider screens, and keeping Coinbase Verification in a compact row while preserving mobile-friendly stacking.
My main motivation was
Shares Per Minute and Extranonce2 Size side-by-sidewhich inspired a bigger code unification. But tbh it's probably not worth the amount of changes, however if @lucasbalieiro likes it we can proceed with it, on my end.