Fix payout verification for split coinbase scriptSig - #614
Merged
GitGab19 merged 2 commits intoJul 13, 2026
Conversation
Member
|
LGTM, but we should bump |
Shourya742
approved these changes
Jul 13, 2026
Shourya742
left a comment
Shourya742
left a comment
Member
There was a problem hiding this comment.
LGTM. After Plebhash's comment on version bumps.
Decode the reconstructed coinbase transaction before checking outputs, using prefix + zeroed extranonce + suffix instead of assuming the suffix starts with outputs. Add coverage for NexusPool-style suffix scriptSig bytes.
GitGab19
force-pushed
the
improve-payout-verification
branch
from
July 13, 2026 14:50
3546b87 to
69e6201
Compare
GitGab19
marked this pull request as draft
July 13, 2026 14:55
Member
Author
|
Turned this into draft since I want to discuss more about the version bumps we need to do here before merging this. |
GitGab19
marked this pull request as ready for review
July 13, 2026 15:27
Member
Author
|
Ok, I confirmed with @plebhash that the bumps are correct. |
plebhash
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #497.
The main problem this solves is the payout verification on
NewExtendedMiningJobmessages which contain the last part of the scriptSig in thecoinbase_tx_suffix, instead of having it entirely in thecoinbase_tx_prefix.I checked on the specs, and there's no mention to the fact that a
coinbase_tx_suffixhas to start withnSequencebytes, which was the assumption used by the mechanism introduced in #497.I also added a new entry into the
translator_mines_when_payout_matches_address_or_donation_identityIT to ensure we correctly deal with such cases.The issue has been found while testing our tProxy against NexusPool endpoint, and this PR fixes that.