Migrate translator to shared synchronous primitive#530
Open
Shourya742 wants to merge 3 commits into
Open
Conversation
Shourya742
force-pushed
the
2026-05-26-migrate-translator-to-shared-map
branch
3 times, most recently
from
May 27, 2026 12:28
f086369 to
4f9d12a
Compare
Shourya742
commented
May 27, 2026
Comment on lines
+200
to
+201
| .with(|data| data.authorized_worker_name == *name) | ||
| .unwrap(); |
Member
Author
There was a problem hiding this comment.
Can't propagate error from Sv1Server downstream message handler, considering it doesn't support TproxyError type.
Member
Author
There was a problem hiding this comment.
Moved forward with UnknownId variant for now, we can extend error enum in Sv1 crate later to include some poison related variant.
Shourya742
force-pushed
the
2026-05-26-migrate-translator-to-shared-map
branch
from
May 27, 2026 12:56
4f9d12a to
26c7b24
Compare
Shourya742
force-pushed
the
2026-05-26-migrate-translator-to-shared-map
branch
from
July 21, 2026 12:14
26c7b24 to
cd0fdd1
Compare
Shourya742
force-pushed
the
2026-05-26-migrate-translator-to-shared-map
branch
from
July 21, 2026 12:27
cd0fdd1 to
2ec31b8
Compare
…wnstream disconnects mid-open
Shourya742
marked this pull request as ready for review
July 21, 2026 16:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.