use error_code constants#495
Merged
plebhash merged 8 commits intoMay 14, 2026
Merged
Conversation
This was referenced May 12, 2026
github-project-automation
Bot
moved this to Todo 📝
in Stratum V2 - 2026 Q3 - Roadmap 📍🗺️
GitGab19
moved this from Todo 📝
to Ready For Review 🔍
in Stratum V2 - 2026 Q3 - Roadmap 📍🗺️
plebhash
force-pushed
the
2026-05-12-error-code-constants
branch
13 times, most recently
from
May 13, 2026 22:42
cb3edb5 to
bce6a32
Compare
GitGab19
reviewed
May 14, 2026
plebhash
force-pushed
the
2026-05-12-error-code-constants
branch
5 times, most recently
from
May 14, 2026 15:34
b7dc9d4 to
ec2098a
Compare
GitGab19
approved these changes
May 14, 2026
Member
|
For me green light on both, let's just remember to drop ec2098a before merging this one. |
plebhash
force-pushed
the
2026-05-12-error-code-constants
branch
from
May 14, 2026 19:37
ec2098a to
cd387a8
Compare
plebhash
force-pushed
the
2026-05-12-error-code-constants
branch
from
May 14, 2026 20:12
cd387a8 to
c0b2265
Compare
plebhash
marked this pull request as ready for review
May 14, 2026 20:14
plebhash
force-pushed
the
2026-05-12-error-code-constants
branch
from
May 14, 2026 21:14
166e40e to
7bf2523
Compare
github-project-automation
Bot
moved this from Ready For Review 🔍
to Done ✅
in Stratum V2 - 2026 Q3 - Roadmap 📍🗺️
github-project-automation
Bot
moved this from Ready For Review 🔍
to Done ✅
in sv2-apps 📱
gimballock
added a commit
to marafoundation/sv2-apps
that referenced
this pull request
May 15, 2026
…d_total Fixes a GaugeVec lazy-loading bug where sv2_*_shares_rejected_total never appears in /metrics until the first rejection occurs, breaking Grafana panels and alerting rules during normal (zero-rejection) operation. Pre-seeds every SubmitSharesError.error_code value defined by mining_sv2 to 0 on every snapshot refresh. Constants come from PR stratum-mining#495 — single source of truth, no string duplication. Schema and PreviousPrometheusLabelSets are unchanged; cleanup happens naturally when channels disappear. +122 lines, -0 lines, purely additive. Includes regression test shares_rejected_metric_emitted_with_zero_rejections which fails on this branch's HEAD and passes with the seed. Verified live on testnet4 slot2: all 7 codes appear at 0 immediately after rebuild.
plebhash
pushed a commit
to plebhash/sv2-apps
that referenced
this pull request
May 15, 2026
…d_total Fixes a GaugeVec lazy-loading bug where sv2_*_shares_rejected_total never appears in /metrics until the first rejection occurs, breaking Grafana panels and alerting rules during normal (zero-rejection) operation. Pre-seeds every SubmitSharesError.error_code value defined by mining_sv2 to 0 on every snapshot refresh. Constants come from PR stratum-mining#495 — single source of truth, no string duplication. Schema and PreviousPrometheusLabelSets are unchanged; cleanup happens naturally when channels disappear. +122 lines, -0 lines, purely additive. Includes regression test shares_rejected_metric_emitted_with_zero_rejections which fails on this branch's HEAD and passes with the seed. Verified live on testnet4 slot2: all 7 codes appear at 0 immediately after rebuild.
plebhash
pushed a commit
to plebhash/sv2-apps
that referenced
this pull request
May 15, 2026
…d_total Fixes a GaugeVec lazy-loading bug where sv2_*_shares_rejected_total never appears in /metrics until the first rejection occurs, breaking Grafana panels and alerting rules during normal (zero-rejection) operation. Pre-seeds every SubmitSharesError.error_code value defined by mining_sv2 to 0 on every snapshot refresh. Constants come from PR stratum-mining#495 — single source of truth, no string duplication. Schema and PreviousPrometheusLabelSets are unchanged; cleanup happens naturally when channels disappear. +122 lines, -0 lines, purely additive. Includes regression test shares_rejected_metric_emitted_with_zero_rejections which fails on this branch's HEAD and passes with the seed. Verified live on testnet4 slot2: all 7 codes appear at 0 immediately after rebuild.
plebhash
pushed a commit
to plebhash/sv2-apps
that referenced
this pull request
May 15, 2026
…d_total Fixes a GaugeVec lazy-loading bug where sv2_*_shares_rejected_total never appears in /metrics until the first rejection occurs, breaking Grafana panels and alerting rules during normal (zero-rejection) operation. Pre-seeds every SubmitSharesError.error_code value defined by mining_sv2 to 0 on every snapshot refresh. Constants come from PR stratum-mining#495 — single source of truth, no string duplication. Schema and PreviousPrometheusLabelSets are unchanged; cleanup happens naturally when channels disappear. +122 lines, -0 lines, purely additive. Includes regression test shares_rejected_metric_emitted_with_zero_rejections which fails on this branch's HEAD and passes with the seed. Verified live on testnet4 slot2: all 7 codes appear at 0 immediately after rebuild.
plebhash
pushed a commit
to plebhash/sv2-apps
that referenced
this pull request
May 18, 2026
…d_total Fixes a GaugeVec lazy-loading bug where sv2_*_shares_rejected_total never appears in /metrics until the first rejection occurs, breaking Grafana panels and alerting rules during normal (zero-rejection) operation. Pre-seeds every SubmitSharesError.error_code value defined by mining_sv2 to 0 on every snapshot refresh. Constants come from PR stratum-mining#495 — single source of truth, no string duplication. Schema and PreviousPrometheusLabelSets are unchanged; cleanup happens naturally when channels disappear. +122 lines, -0 lines, purely additive. Includes regression test shares_rejected_metric_emitted_with_zero_rejections which fails on this branch's HEAD and passes with the seed. Verified live on testnet4 slot2: all 7 codes appear at 0 immediately after rebuild.
xyephy
pushed a commit
to xyephy/sv2-apps
that referenced
this pull request
May 27, 2026
…d_total Fixes a GaugeVec lazy-loading bug where sv2_*_shares_rejected_total never appears in /metrics until the first rejection occurs, breaking Grafana panels and alerting rules during normal (zero-rejection) operation. Pre-seeds every SubmitSharesError.error_code value defined by mining_sv2 to 0 on every snapshot refresh. Constants come from PR stratum-mining#495 — single source of truth, no string duplication. Schema and PreviousPrometheusLabelSets are unchanged; cleanup happens naturally when channels disappear. +122 lines, -0 lines, purely additive. Includes regression test shares_rejected_metric_emitted_with_zero_rejections which fails on this branch's HEAD and passes with the seed. Verified live on testnet4 slot2: all 7 codes appear at 0 immediately after rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
companion stratum-mining/stratum#2151