Skip to content

Remove vec slice encodable binary sv2 - #2295

Merged
GitGab19 merged 5 commits into
stratum-mining:mainfrom
bit-aloo:2026-08-13-remove-vec-slice-encodable-binary-sv2
Aug 14, 2026
Merged

Remove vec slice encodable binary sv2#2295
GitGab19 merged 5 commits into
stratum-mining:mainfrom
bit-aloo:2026-08-13-remove-vec-slice-encodable-binary-sv2

Conversation

@bit-aloo

Copy link
Copy Markdown
Member

closes: #2217

@GitGab19 GitGab19 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clanker finding, non-blocking:

Remove the stale BYTES mapping from the documentation. The PR removes the implementations that made raw byte vectors encodable, but both the crate documentation and README still advertise [u8] <-> BYTES. Users following that documentation will encounter missing trait implementations. Remove those rows or explain that BYTES is handled by framing context rather than binary_sv2.

@bit-aloo

Copy link
Copy Markdown
Member Author

Clanker finding, non-blocking:

Remove the stale BYTES mapping from the documentation. The PR removes the implementations that made raw byte vectors encodable, but both the crate documentation and README still advertise [u8] <-> BYTES. Users following that documentation will encounter missing trait implementations. Remove those rows or explain that BYTES is handled by framing context rather than binary_sv2.

Thanks, and also added the reason why we are removing it.

@GitGab19
GitGab19 merged commit 905cf73 into stratum-mining:main Aug 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove From<Vec<u8>> and From<Slice> from binary_sv2

2 participants