allow access to all sv1 message props#2224
Open
coleFD wants to merge 2 commits into
Open
Conversation
plebhash
reviewed
Jul 9, 2026
Member
There was a problem hiding this comment.
missing this one
is that intentional, or not needed for your use-case @coleFD ?
Collaborator
Author
There was a problem hiding this comment.
nope just missed it
plebhash
reviewed
Jul 9, 2026
Comment on lines
681
to
684
| pub struct VersionRollingParams { | ||
| mask: Option<HexU32Be>, | ||
| min_bit_count: Option<HexU32Be>, | ||
| pub mask: Option<HexU32Be>, | ||
| pub min_bit_count: Option<HexU32Be>, | ||
| } |
Member
There was a problem hiding this comment.
making these fields public means VersionRollingParams can now be instantiated with combinations we currently treat as invalid when parsing.
for example:
VersionRollingParams { mask: None, min_bit_count: Some(HexU32Be(0x10)) }ConfigureExtension::from_value explicitly rejects this shape ((None, Some(_)) => Err(...)).
so I wonder whether it wouldn't be safer to change the PR approach, while keeping internal values private and exposing getters instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make fields in sv1 messages public