Repository navigation
docs: tweak pr-writer skill to be more concise - #3148
Merged
opieter-aws merged 1 commit intoJul 9, 2026
Merged
opieter-aws merged 1 commit into
opieter-aws merged 1 commit into
Conversation
opieter-aws
marked this pull request as ready for review
July 9, 2026 15:18
Contributor
|
Assessment: Approve Focused, low-risk change to the Review Categories
Nice job pairing the wording change with actual before/after generation data rather than just asserting it reads better. |
zastrowm
approved these changes
Jul 9, 2026
This was referenced Jul 10, 2026
This was referenced Jul 21, 2026
Merged
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
pr-writerskill was producing PR descriptions that ran long and restated the diff instead of explaining the change — heavy on the "what," light on the "why." A reviewer flagged exactly this on #3131. The skill already said "focus on why" and "be concise," but that guidance was abstract and buried among many rules, so it didn't reliably shape the output.Related Issues
Prompted by review feedback on #3131.
Documentation PR
None
Type of Change
Other (please describe): Updates the
pr-writercontributor skill (agent tooling guidance). No product code or site docs.Testing
Ran the updated skill against the diff from #3131 — the PR that triggered the feedback — across 10 independent generations. Descriptions came out consistently why-first and concise, averaging ~100 words versus ~370 in the original. The first pass surfaced one leak: fixture/mock narration was relocating into the Testing section rather than disappearing. The rule was broadened to cover the whole PR, which is the state here.
(No
hatch run prepare— this is a skill-doc change with no Python surface, so that gate doesn't apply.)hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.