Fix txHash type #545
Merged
Fix txHash type #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for consistency and improved type safety.
…Id is already attached, and adjust corresponding test case for clarity.
bonnie57
requested review from
LeoHChen,
DonFungible,
edisonz0718,
jacob-tucker,
AndyBoWu,
allenchuang,
bpolania,
DracoLi,
limengformal and
lucas2brh
as code owners
lucas2brh
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
txHashtype fromstringandHexintotxHash.Notes
Removing
txHashwhen attachLicenseTerms given licenseTermsId is already attached. @bpolania, there is a breaking change, and we need to highlight it in the release notes.