Skip to content

Fix txHash type #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Fix txHash type #545

merged 2 commits into from
May 26, 2025

Conversation

bonnie57
Copy link
Collaborator

Description

Fix txHash type from string and Hex into txHash.

Notes

Removing txHash when attachLicenseTerms given licenseTermsId is already attached. @bpolania, there is a breaking change, and we need to highlight it in the release notes.

bonnie57 added 2 commits May 22, 2025 10:00
…es for consistency and improved type safety.
…Id is already attached, and adjust corresponding test case for clarity.
Copy link
Collaborator

@bpolania bpolania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bonnie57 bonnie57 merged commit bc0641c into main May 26, 2025
20 checks passed
@bonnie57 bonnie57 deleted the fix/txHash-type branch May 29, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants