Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(story): add README to story starter #23

Merged
merged 5 commits into from
Jan 5, 2024
Merged

docs(story): add README to story starter #23

merged 5 commits into from
Jan 5, 2024

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Dec 28, 2023 •
edited
Loading

What?

This PR adds README to Story Starter.

[View Rendered →]

Why?

JIRA: EXT-2128

How to test? (optional)

This was referenced Dec 28, 2023
Merged
Merged
Merged
Merged
Merged
@eunjae-lee
Copy link
Contributor Author

eunjae-lee commented Dec 28, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@eunjae-lee
Copy link
Contributor Author

Maybe I need to reduce the image sizes 🤔

@eunjae-lee
Copy link
Contributor Author

This is a very first draft of the README. What else should we have here? 🙂

demetriusfeijoo
demetriusfeijoo reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@demetriusfeijoo demetriusfeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eunjae-lee, aewsome 💯

I've left some comments but nothing which would prevent this PR to be merged. 💯

I was wondering about adding also a screenshot with the final result... what do you think?

story-starter/package.json Show resolved Hide resolved
story-starter/README.md Outdated Show resolved Hide resolved
@demetriusfeijoo
Copy link
Contributor

Maybe I need to reduce the image sizes 🤔

Maybe we could try using some tool such as https://tinypng.com/, what do you think?

@eunjae-lee
Copy link
Contributor Author

Maybe I need to reduce the image sizes 🤔

Maybe we could try using some tool such as https://tinypng.com/, what do you think?

@demetriusfeijoo Oh I phrased it wrongly. I meant image resolutions. It looks too big. I'll try something soon here.

@eunjae-lee eunjae-lee force-pushed the EXT-2147-do-not-keep-selection-between-pages branch from 21b6ffa to d2222b9 Compare January 3, 2024 13:53
@eunjae-lee eunjae-lee force-pushed the EXT-2128-documentation branch from 27f955a to f146bc8 Compare January 3, 2024 13:53
@eunjae-lee
Copy link
Contributor Author

@demetriusfeijoo I updated the image sizes be9fc4d

@eunjae-lee eunjae-lee force-pushed the EXT-2147-do-not-keep-selection-between-pages branch from d2222b9 to 253615c Compare January 4, 2024 09:46
Base automatically changed from EXT-2147-do-not-keep-selection-between-pages to main January 4, 2024 09:48
@eunjae-lee eunjae-lee force-pushed the EXT-2128-documentation branch from dd9078a to 8b25e53 Compare January 4, 2024 10:01
@eunjae-lee @demetriusfeijoo
Update story-starter/README.md
c178085 
Co-authored-by: Demetrius Feijóo <[email protected]>
@demetriusfeijoo demetriusfeijoo self-requested a review January 5, 2024 10:28
demetriusfeijoo
demetriusfeijoo approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@demetriusfeijoo demetriusfeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aewsome, @eunjae-lee. 🚀

@eunjae-lee eunjae-lee merged commit 4f47930 into main Jan 5, 2024
1 check passed
@eunjae-lee eunjae-lee deleted the EXT-2128-documentation branch January 5, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demetriusfeijoo demetriusfeijoo demetriusfeijoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjae-lee @demetriusfeijoo