feat(story): add tailwind css + daisy ui #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't put much design, but added some basic class names. Screenshot.2023-12-06.at.11.39.33.mp4We still need to have proper heading, and etc (in a separate PR) ← you can take it if you'd like to try out Tailwind + DaisyUI @BibiSebi |
demetriusfeijoo
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Nice, @eunjae-lee. 💯
It was easy to understand what was done. 🙌
BibiSebi
reviewed
Dec 7, 2023
| plugins: [require('daisyui')], | ||
| daisyui: { | ||
| themes: [ | ||
| { |
There was a problem hiding this comment.
At some point, this specific part can be a part of the shared library as well. WDYT?
There was a problem hiding this comment.
Yeah that'd be really nice :)
We could even release it on npm and use it for other projects!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds tailwind css and daisy ui.
Why?
JIRA: EXT-2127
How to test? (optional)