feat!: A few things to make egress work #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to know the DID's key, just the DID itself. Therefore, we should take only the DID. Otherwise, code which wants to pass in a Space but only has the (string) DID must parse it into a full `Principal` first.
|
Can you elaborate on the fetch related change? I don't follow. What is the issue and why does changing it to this help? |
5 tasks
Peeja
changed the title
|
@alanshaw Honestly, I don't totally understand the mechanics, but the upshot is that you end up with a |
|
It sounds like a problem specific to cloudflare workers and I'd be inclined to move the solution over there, as in leave the option the same here but in cloudflare workers pass |
|
Yeah, I buy that. |
alanshaw
previously approved these changes
Nov 27, 2024
alanshaw
approved these changes
Nov 29, 2024
Peeja
added a commit
that referenced
this pull request
Nov 29, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.0](v1.1.3...v2.0.0) (2024-11-29) ### ⚠ BREAKING CHANGES * A few things to make egress work ([#7](#7)) * Match with `DID`s, not `Principal`s ### Features * A few things to make egress work ([#7](#7)) ([aabacb9](aabacb9)) * Match with `DID`s, not `Principal`s ([674d22f](674d22f)) ### Bug Fixes * Make completely sure `fetch` works ([6bf83ac](6bf83ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of storacha/project-tracking#140
DIDs, notPrincipals: We don't need to know the DID's key, just the DID itself. Therefore, we should take only the DID. Otherwise, code which wants to pass in a Space but only has the (string) DID must parse it into a fullPrincipalfirst.fetchworks: Wrangler does weird things with proxies that make.bind()not sufficient.CAR.coderather than magic number: Only because I read this line and wasn't sure which code it was without looking it up.