Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACM-15724] Observability - RBAC - Verify only cluster-manager-admin role can deploy MCO CR #1912

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[ACM-15724] Observability - RBAC - Verify only cluster-manager-admin role can deploy MCO CR #1912

wants to merge 7 commits into from

Conversation

coleenquadros
Copy link
Contributor

@coleenquadros coleenquadros commented Mar 17, 2025 •
edited
Loading

https://issues.redhat.com/browse/ACM-15724
This test is only going to check the policy to be able to delete MCO resource with the users respective clusterrole bindings instead of actually deploying or trying to delete MCO and waiting for the deployment to come up to reduce e2e run time

@coleenquadros
check rbac for deleting mco
e105d1d 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
test mco rbac
c418dba 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
Copy link
Contributor Author

/test test-e2e

1 similar comment
@coleenquadros
Copy link
Contributor Author

/test test-e2e

@coleenquadros
refactor
c432c06 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
Copy link
Contributor Author

/test test-e2e

@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
cleanup users and identity before setup
b61ada8 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
Copy link
Contributor Author

/test pr-image-mirror-rbac-query-proxy

@coleenquadros coleenquadros changed the title Observability - RBAC - Verify only cluster-manager-admin role can deploy MCO CR [ACM-15724] Observability - RBAC - Verify only cluster-manager-admin role can deploy MCO CR Mar 19, 2025
@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
debug
9f6e0a6 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
update
7181617 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subbarao-meduri subbarao-meduri Awaiting requested review from subbarao-meduri

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
approved dco-signoff: yes needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coleenquadros @openshift-merge-robot