Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CNV single cluster view dashboard #1864

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sradco
Copy link
Contributor

@sradco sradco commented Feb 24, 2025

Update CNV single cluster view dashboard.
Grouped resources utilization based on resource,
Added CPU delay.

Signed-off-by: Shirly Radco [email protected]

Copy link

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sradco
Once this PR has been reviewed and has the lgtm label, please assign dislbenn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sradco sradco force-pushed the update_single_cluster_view_dashboard branch from 0821d1b to b8b358e Compare February 24, 2025 20:07
@jacobbaungard
Copy link
Contributor

Hi, following PR: #1726 we also need to add new metrics to the scrape-config (found in the same folder as the dashboard, here for virt: https://github.com/stolostron/multicluster-observability-operator/blob/main/operators/multiclusterobservability/manifests/base/grafana/virtualization/scrape-config.yaml).

Please add the new collected metric there and it should make the test pass.

@sradco sradco force-pushed the update_single_cluster_view_dashboard branch from b8b358e to d9252c0 Compare March 18, 2025 08:44
@sradco
Copy link
Contributor Author

sradco commented Mar 18, 2025

Hi @moadz , The PR is ready for review.

Copy link

openshift-ci bot commented Mar 18, 2025

@sradco: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e d9252c0 link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Update CNV single cluster view dashboard.
Grouped resources utilization based on resource,
Added CPU delay.

Signed-off-by: Shirly Radco <[email protected]>
@sradco sradco force-pushed the update_single_cluster_view_dashboard branch from d9252c0 to 12dfd5a Compare March 24, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants