Update virtual machines inventory dashboard

[sradco]

Update virtual machines inventory dashboard.
Added additional information about the VMs.

Signed-off-by: Shirly Radco sradco@redhat.com

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sradco
Once this PR has been reviewed and has the lgtm label, please assign thibaultmg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jacobbaungard]

/retest

[jacobbaungard]

Hi, following PR: #1726 we also need to add new metrics to the scrape-config (found in the same folder as the dashboard, here for virt: https://github.com/stolostron/multicluster-observability-operator/blob/main/operators/multiclusterobservability/manifests/base/grafana/virtualization/scrape-config.yaml).

Please add the new collected metric there and it should make the test pass.

[jacobbaungard]

Could you also add kubevirt_vm_create_date_timestamp_seconds to the ignoredMetrics list in https://github.com/stolostron/multicluster-observability-operator/blob/main/tests/pkg/tests/observability_metrics_test.go#L264

I believe this should make the test-e2e pass.

[sradco]

Hi @moadz , The PR is ready for review.

[sradco]

Could you also add kubevirt_vm_create_date_timestamp_seconds to the ignoredMetrics list in https://github.com/stolostron/multicluster-observability-operator/blob/main/tests/pkg/tests/observability_metrics_test.go#L264

I believe this should make the test-e2e pass.

Hi @jacobbaungard, Why do I need to add the metric to the ignoredMetrics list?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[openshift-ci]

@sradco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	2b0dc1b	link	true	/test images
ci/prow/test-e2e	2b0dc1b	link	true	/test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.