Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 🐛 Add Relationship and correct the update operations #1163

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

clyang82
Copy link
Contributor

@clyang82 clyang82 commented Oct 11, 2024

Summary

  1. distinguish create and update inspired from 🐛 Distinguish the creating/updating the event  #1154 Thanks @yanmxa
  2. Correct the usage for update and delete
  3. Add labels to the request metadata
  4. Add relationship for the policy to show the status

Related issue(s)

Fixes #https://issues.redhat.com/browse/ACM-14812

Tests

  • Unit/function tests have been added and incorporated into make unit-tests.
  • Integration tests have been added and incorporated into make integration-test.
  • E2E tests have been added and incorporated into make e2e-test-all.
  • List other manual tests you have done.
  • tested in local environment and have a demo for it.

Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
@clyang82 clyang82 changed the title :sparkles 🐛 Add Relationship and correct the update operations ✨ 🐛 Add Relationship and correct the update operations Oct 14, 2024
Signed-off-by: clyang82 <[email protected]>
Copy link

@yanmxa
Copy link
Member

yanmxa commented Oct 14, 2024

/lgtm

Copy link

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cab516e into stolostron:main Oct 14, 2024
14 checks passed
@clyang82 clyang82 deleted the relationship branch October 14, 2024 05:37
@clyang82
Copy link
Contributor Author

/cherry-pick release-2.12

@openshift-cherrypick-robot
Copy link
Contributor

@clyang82: new pull request created: #1164

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@clyang82
Copy link
Contributor Author

/cherry-pick release-2.12

@openshift-cherrypick-robot
Copy link
Contributor

@clyang82: new pull request created: #1217

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants