Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bump the postgres SSL min protocol version from 1.2 to 1.3 #1162

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

yanmxa
Copy link
Member

@yanmxa yanmxa commented Oct 11, 2024

Summary

Fix the warning "vulnerable cipher usage in service/multicluster-global-hub-postgres"

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-14622

Tests

  • Unit/function tests have been added and incorporated into make unit-tests.
  • Integration tests have been added and incorporated into make integration-test.
  • E2E tests have been added and incorporated into make e2e-test-all.
  • List other manual tests you have done.
$ oc port-forward service/multicluster-global-hub-postgres 8123:5432
...
$ nmap -Pn -sV --script ssl-enum-ciphers -p 8123 localhost
Starting Nmap 7.95 ( https://nmap.org ) at 2024-10-11 11:29 CST
Nmap scan report for localhost (127.0.0.1)
Host is up (0.00033s latency).
Other addresses for localhost (not scanned): ::1

PORT     STATE SERVICE    VERSION
8123/tcp open  postgresql PostgreSQL DB 9.6.0 or later
| ssl-enum-ciphers:
|   TLSv1.3:
|     ciphers:
|       TLS_AKE_WITH_AES_256_GCM_SHA384 (secp256r1) - A
|       TLS_AKE_WITH_CHACHA20_POLY1305_SHA256 (secp256r1) - A
|       TLS_AKE_WITH_AES_128_GCM_SHA256 (secp256r1) - A
|       TLS_AKE_WITH_AES_128_CCM_SHA256 (secp256r1) - A
|     cipher preference: server
|_  least strength: A

Service detection performed. Please report any incorrect results at https://nmap.org/submit/ .
Nmap done: 1 IP address (1 host up) scanned in 38.35 seconds

Copy link

@yanmxa
Copy link
Member Author

yanmxa commented Oct 11, 2024

/cc @clyang82 @ldpliu

@openshift-ci openshift-ci bot requested review from clyang82 and ldpliu October 11, 2024 10:16
@clyang82
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8e3a351 into stolostron:main Oct 12, 2024
15 checks passed
@clyang82
Copy link
Contributor

clyang82 commented Nov 7, 2024

/cherry-pick release-2.12

@openshift-cherrypick-robot
Copy link
Contributor

@clyang82: new pull request created: #1207

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants