Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Clean the transport connection #1160

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

clyang82
Copy link
Contributor

Summary

the manager is waiting for the transport connection. in the first time, the transport connection is empty. once the kafka is ready, the transport connection will be set as correct value. when reinstall, the transport connection keeps the previous value so that the manager and grafana will be deploy at the beginning.

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-14761

Tests

  • Unit/function tests have been added and incorporated into make unit-tests.
  • Integration tests have been added and incorporated into make integration-test.
  • E2E tests have been added and incorporated into make e2e-test-all.
  • List other manual tests you have done.
  • tested in local environment for the re-installation

@yanmxa
Copy link
Member

yanmxa commented Oct 10, 2024

/lgtm

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82
Copy link
Contributor Author

/cherry-pick release-2.12

@openshift-cherrypick-robot
Copy link
Contributor

@clyang82: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@openshift-merge-bot openshift-merge-bot bot merged commit 73cc72e into stolostron:main Oct 10, 2024
14 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@clyang82: new pull request created: #1161

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants