📝 Refactor the structure of the global hub agent #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanmxa
force-pushed
the
br_agent_refactor
branch
from
c393ef7 to
3047426
Compare
yanmxa
force-pushed
the
br_agent_refactor
branch
2 times, most recently
from
2063132 to
f23249f
Compare
yanmxa
changed the title
|
/retest |
yanmxa
force-pushed
the
br_agent_refactor
branch
from
5fb6ccc to
6b14986
Compare
|
Prow issue, retest it INFO[2024-10-12T10:10:10Z] Ran for 0s
ERRO[2024-10-[12](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/stolostron_multicluster-global-hub/1156/pull-ci-stolostron-multicluster-global-hub-main-test-integration/1845044250014650368#1:build-log.txt%3A12)T10:10:10Z] Some steps failed:
ERRO[2024-10-12T10:10:10Z]
* could not initialize namespace: could not update namespace to add labels, TTLs and active annotations: Operation cannot be fulfilled on namespaces "ci-op-t6xf1z2c": the object has been modified; please apply your changes to the latest version and try again
INFO[2024-10-12T10:10:10Z] Reporting job state 'failed' with reason 'initializing_namespace'/test test-integration |
|
/test test-integration |
Signed-off-by: myan <[email protected]> add Signed-off-by: myan <[email protected]> format agent Signed-off-by: myan <[email protected]> add the document Signed-off-by: myan <[email protected]> document Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
yanmxa
force-pushed
the
br_agent_refactor
branch
from
6ca007a to
64b98e1
Compare
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
|
clyang82
approved these changes
Oct 15, 2024
| @@ -9,7 +9,7 @@ COPY go.mod go.sum ./ | |||
| COPY ./agent/ ./agent/ | |||
| COPY ./pkg/ ./pkg/ | |||
|
|
|||
| RUN go build -o bin/agent ./agent/cmd/agent/main.go | |||
| RUN go build -o bin/agent ./agent/cmd/main.go | |||
There was a problem hiding this comment.
Need to update the downstream for this change
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes # https://issues.redhat.com/browse/ACM-14760
Tests
make unit-tests.make integration-test.make e2e-test-all.