Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-17421] Add modal for VM actions #4359

Merged
merged 8 commits into from
Mar 24, 2025

Conversation

zlayne
Copy link
Contributor

@zlayne zlayne commented Mar 20, 2025

The new modal prompts the user before triggering the action to make sure they meant to click the action in context.

Screenshot 2025-03-20 at 9 39 33 AM

zlayne added 2 commits March 20, 2025 10:33
Signed-off-by: zlayne <[email protected]>
@zlayne
Copy link
Contributor Author

zlayne commented Mar 20, 2025

/test unit-tests-sonarcloud

@zlayne
Copy link
Contributor Author

zlayne commented Mar 20, 2025

/retest

zlayne added 2 commits March 20, 2025 15:30
Signed-off-by: zlayne <[email protected]>
Signed-off-by: zlayne <[email protected]>
@zlayne
Copy link
Contributor Author

zlayne commented Mar 21, 2025

/test unit-tests-sonarcloud

@zlayne
Copy link
Contributor Author

zlayne commented Mar 23, 2025

/retest

@zlayne zlayne requested a review from KevinFCormier March 23, 2025 23:58
@KevinFCormier
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, zlayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KevinFCormier,zlayne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 14c2237 into stolostron:main Mar 24, 2025
9 checks passed
@zlayne zlayne deleted the vm-action-modal branch March 24, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants