WIP - Test build for @stolostron/multicluster-sdk with ODF extensions

Dockerfile.mce.prow

@@ -8,8 +8,11 @@ RUN npm run build:plugin:mce
 
 FROM registry.ci.openshift.org/stolostron/builder:nodejs20-linux as backend
 WORKDIR /app/backend
-COPY ./backend .
+# Copy only package.json and package-lock.json so that the docker layer cache only changes if those change
+# This will cause the npm ci to only rerun if the package.json or package-lock.json changes
+COPY ./backend/package.json ./backend/package-lock.json ./
 RUN npm ci --omit=optional
+COPY ./backend .
 RUN npm run build
 
 FROM registry.ci.openshift.org/stolostron/builder:nodejs20-linux as production

Dockerfile.prow

@@ -1,14 +1,9 @@
 # Copyright Contributors to the Open Cluster Management project
 
-FROM registry.ci.openshift.org/stolostron/builder:nodejs20-linux as frontend-packages
+FROM registry.ci.openshift.org/stolostron/builder:nodejs20-linux as dynamic-plugin
 WORKDIR /app/frontend
-# Copy only package.json and package-lock.json so that the docker cache hash only changes if those change
-# This will cause the npm ci to only rerun if the package.json or package-lock.json changes
-COPY ./frontend/package.json ./frontend/package-lock.json ./
-RUN npm ci --legacy-peer-deps
 COPY ./frontend .
-
-FROM frontend-packages as dynamic-plugin
+RUN npm ci --legacy-peer-deps
 RUN npm run build:plugin:acm
 
 FROM registry.ci.openshift.org/stolostron/builder:nodejs20-linux as backend

frontend/package.json

@@ -13,6 +13,7 @@
     "build:plugin": "./scripts/checkPlugin.sh && cd plugins/${PLUGIN} && node ../../scripts/generatePluginPackage.js && TS_NODE_PROJECT=../../webpack.tsconfig.json webpack -c ../../webpack.plugin.ts --env plugin=$PLUGIN --mode production",
     "build:plugin:acm": "PLUGIN=acm npm run build:plugin",
     "build:plugin:mce": "PLUGIN=mce npm run build:plugin",
+    "build:workspaces": "npm run build --workspaces --if-present",
     "check": "npm run i18n && npm run prettier && npm run lint && npm run tsc",
     "check:fix": "npm run i18n:fix && npm run prettier:fix && npm run lint:fix && npm run tsc",
     "clean": "rm -rf coverage build",
@@ -21,6 +22,7 @@
     "jest:update-snapshot": "jest --updateSnapshot",
     "lint": "eslint src --ext .js,.jsx,.ts,.tsx --max-warnings=0",
     "lint:fix": "npm run lint -- --fix",
+    "postinstall": "npm run build:workspaces",
     "prettier": "prettier --check src public",
     "prettier:fix": "prettier --write src public",
     "i18n": "i18next --fail-on-warnings && git diff --exit-code public/locales/en/translation.json",
@@ -364,11 +366,8 @@
       "last 1 safari version"
     ]
   },
-  "prettier": {
-    "printWidth": 120,
-    "tabWidth": 2,
-    "semi": false,
-    "singleQuote": true,
-    "trailingComma": "es5"
-  }
+  "prettier": "@stolostron/prettier-config",
+  "workspaces": [
+    "packages/*"
+  ]
 }

frontend/packages/multicluster-sdk/.gitignore

@@ -0,0 +1 @@
+lib

frontend/packages/multicluster-sdk/package.json

@@ -0,0 +1,40 @@
+{
+  "name": "@stolostron/multicluster-sdk",
+  "version": "0.1.0",
+  "description": "Provides extensions and APIs that dynamic plugins can use to leverage multicluster capabilities provided by Red Hat Advanced Cluster Management.",
+  "main": "lib/index.js",
+  "types": "lib/index.d.ts",
+  "files": [
+    "lib"
+  ],
+
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/stolostron/console.git"
+  },
+  "keywords": [
+    "multicluster",
+    "RHACM",
+    "ACM",
+    "SDK",
+    "OpenShift",
+    "dynamic plugin",
+    "Red Hat"
+  ],
+  "license": "Apache-2.0",
+  "homepage": "https://github.com/stolostron/console/tree/main/frontend/packages/multicluster-sdk#readme",
+  "scripts": {
+    "build": "tsc --build",
+    "tsc": "tsc --no-emit",
+    "prettier": "prettier --check src",
+    "prettier:fix": "prettier --write src"
+  },
+  "peerDependencies": {
+    "@openshift-console/dynamic-plugin-sdk": "1.x"
+  },
+  "devDependencies": {
+    "prettier": "^3.2.5",
+    "typescript": "^5.6.3"
+  },
+  "prettier": "@stolostron/prettier-config"
+}

frontend/packages/multicluster-sdk/src/index.ts

@@ -0,0 +1,3 @@
+/* Copyright Contributors to the Open Cluster Management project */
+export * from './extensions'
+export * from './properties'

frontend/packages/multicluster-sdk/tsconfig.json

@@ -0,0 +1,8 @@
+{
+   "extends": "../../tsconfig.json",
+   "compilerOptions": {
+        "outDir": "lib",
+        "noEmit": false
+    },
+    "include": ["src"]
+}

frontend/packages/prettier-config/index.js

@@ -0,0 +1,12 @@
+/**
+ * @type {import("prettier").Config}
+ */
+const config = {
+  "printWidth": 120,
+  "tabWidth": 2,
+  "semi": false,
+  "singleQuote": true,
+  "trailingComma": "es5",
+};
+
+export default config;

frontend/packages/prettier-config/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "@stolostron/prettier-config",
+  "version": "0.0.0",
+  "private": true,
+  "type": "module",
+  "exports": "./index.js",
+  "license": "Apache-2.0"
+}

frontend/src/plugin-extensions/handler.ts

@@ -1,7 +1,7 @@
 /* Copyright Contributors to the Open Cluster Management project */
 import { useResolvedExtensions } from '@openshift-console/dynamic-plugin-sdk'
-import { isApplicationAction, isApplicationListColumn, isOverviewTab } from './extensions'
-import { ApplicationActionProps, ApplicationListColumnProps } from './properties'
+import { isApplicationAction, isApplicationListColumn, isOverviewTab } from '@stolostron/multicluster-sdk'
+import { ApplicationActionProps, ApplicationListColumnProps } from '@stolostron/multicluster-sdk'
 import { AcmExtension } from './types'
 
 // Type guards

frontend/src/plugin-extensions/types.ts

@@ -1,7 +1,7 @@
 /* Copyright Contributors to the Open Cluster Management project */
 import { ResolvedExtension } from '@openshift-console/dynamic-plugin-sdk'
-import { ApplicationActionProps, ApplicationListColumnProps } from './properties'
-import { OverviewTab } from './extensions'
+import { ApplicationActionProps, ApplicationListColumnProps } from '@stolostron/multicluster-sdk'
+import { OverviewTab } from '@stolostron/multicluster-sdk'
 
 export type AcmExtension = Partial<{
   applicationAction: ApplicationActionProps[]

frontend/src/routes/Applications/Application.sharedmocks.tsx

@@ -41,7 +41,7 @@ import {
   SubscriptionOperatorKind,
 } from '../../resources'
 import { AcmExtension } from '../../plugin-extensions/types'
-import { ApplicationActionProps } from '../../plugin-extensions/properties'
+import { ApplicationActionProps } from '@stolostron/multicluster-sdk'
 import { IResultStatuses } from '../../lib/useAggregates'
 
 export const mockArgoCD: IResource = {

frontend/src/routes/Applications/ApplicationDetails/ApplicationDetails.test.tsx

@@ -20,7 +20,7 @@ import {
 import { nockIgnoreApiPaths, nockIgnoreRBAC, nockSearch } from '../../../lib/nock-util'
 import { defaultPlugin, PluginContext } from '../../../lib/PluginContext'
 import { waitForText } from '../../../lib/test-util'
-import { ApplicationActionProps } from '../../../plugin-extensions/properties'
+import { ApplicationActionProps } from '@stolostron/multicluster-sdk'
 import { AcmExtension } from '../../../plugin-extensions/types'
 import { GetMessagesDocument, SearchSchemaDocument } from '../../Search/search-sdk/search-sdk'
 import {

scripts/copyright.ts

@@ -2,7 +2,7 @@
 import { lstat, readdir, readFile, writeFile } from 'fs/promises'
 import { join } from 'path'
 
-const ignoreDirectories = ['.git', 'node_modules', 'coverage', 'build', 'dist']
+const ignoreDirectories = ['.git', 'node_modules', 'coverage', 'build', 'dist', 'lib']
 const extensions = ['.ts', '.tsx', '.js']
 
 export type CopyrightAction = (path: string) => Promise<boolean>