[release-2.13] Fix mapping file marshalling #1251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dryrun worked when users didn't specify a mappings file. When users provide one, the dryrun didn't manually create the mappings file. It displays "Error: the resource version was not found for kind LimitRange: if this is a custom resource, it may need an entry in the mappings file" instead. Ref: https://issues.redhat.com/browse/ACM-18134 Signed-off-by: yiraeChristineKim <[email protected]> (cherry picked from commit 1fd6fabd881552cd9cc60e88468414ce183a7aff)
Signed-off-by: yiraeChristineKim <[email protected]> (cherry picked from commit ae83665d98b258df6ef3584d977ab7f3bbd7d67a)
Signed-off-by: Dale Haiducek <[email protected]> (cherry picked from commit 0d84aeeea563064a485087f52fdc0380a4d516d8)
|
/hold for v2.13.1 |
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of:
ref: https://issues.redhat.com/browse/ACM-18134