-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report enhancements #96
Conversation
this helps explain why all of the fields are for some workflows
There might have been a better way to do # 3 feat: note in state if workflows are disabled as opposed to setting it individually for each save csv, json, and markdown functions, but without refactoring the code I didn't see anywhere obvious since the workflow API returns empty and thus this line never gets hit. |
# Conflicts: # .github/workflows/scorecard.yml
Thanks for the contributions @joshjohanning |
I agree, but your changes look great here. |
I have deleted the scorecard. |
🙇 thanks for the review and merge @stoe! 🎉 |
📝 Summary
🔍 Details
1. fix: .com workflow link in md report
If you are pulling in workflows from .com, the url in the markdown was
https://undefined/org/repo..
.Like this:
This worked correctly as-is for GHES, though (and tested to work still after the change).
2. feat: support local actions in md report
Local actions showed up in the
CSV
andJSON
reports, and I added some logic to bring in local actions to theMD
report. It uses "(local)
" as the version instead of the ref/tag that regular actions use. The local action links to the directory in the repo where the action is stored.A local action will look like this in the report:
3. feat: note in state if workflows are disabled
I was trying to figure out why some workflows were showing
undefined
for things likename
andstate
. Originally I thought it was just because they had never been run before since thecreated_at
andupdated_at
was alsoundefined
, but I was still curious why thename
property would return backundefined
.I think the cause of this is that with forks, if you don't enable workflows to be run against the repository, the API returns empty
I'm adding the
Workflows not enabled in fork
to the status field in this case.4. style: run prettier
🔗 Related Issues