Repository navigation
chore: update adslib submodule to 113.0.34-1 and rename adslib.so -> AdsLib.so - #537
Merged
Merged
Conversation
Bump the adslib submodule from 77953d5 (113.0.33-1) to 67886519 (113.0.34-1) to pick up the latest upstream AdsLib release.
The upstream AdsLib project renamed the library output from libadslib.so to libAdsLib.so in Beckhoff/ADS@ca978d7. Update all references in documentation, setup.py, and pyads_ex.py to use the correct case-sensitive library name. Also bump the adslib submodule to 6788651. Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com> Assisted-by: OpenCode:claude-opus-4.6
Coverage Report for CI Build 27577078852Coverage remained the same at 93.575%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adslibsubmodule from77953d58(113.0.33-1) to67886519(113.0.34-1).adslib.sotoAdsLib.so(README, docs,setup.py,pyads_ex.py) to match the renamed library output in upstream Beckhoff/ADS@ca978d7.setup.pywith the macOS_adslib_shared_lib_name()helper added in fix: macOS wheel build fails due to libadslib.dylib vs .so #534: it now returnslibAdsLib.so/libAdsLib.dylib.Test plan
adslibvia meson/ninja and confirmedlibAdsLib.sois produced and packaged asAdsLib.sopip install .into a clean venv succeeds andAdsLib.sois importablepytest- 119 passed