Repository navigation
Conversation
PR stlehmann#515 added support for zero-length write requests (plc_data_type=None) in adsSyncWriteReqEx but did not update the type annotations to reflect that None is now an accepted value. Update the annotations on adsSyncWriteReqEx and Connection.write to Optional[Type], and add a test covering the zero-length write use-case. https://claude.ai/code/session_01QKx2yv6cnjKgJAeHkU6JEG
stlehmann
approved these changes
May 31, 2026
stlehmann
left a comment
stlehmann
left a comment
Owner
There was a problem hiding this comment.
Nice and clean PR. @chrisbeardy which agent did you use for this?
Collaborator
Author
All done from the comfort of my sofa using Claude code from the phone app. Remarkable. I use Claude Code extensively at work now and given the right amount of oversight its a powerful tool. I should probably let it have a go more on pyads, especially on existing problems and review. |
stlehmann
added a commit
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human Note: AI generated but seems to check out
PR #515 added support for zero-length write requests (plc_data_type=None) in adsSyncWriteReqEx but did not update the type annotations to reflect that None is now an accepted value. Update the annotations on adsSyncWriteReqEx and Connection.write to Optional[Type], and add a test covering the zero-length write use-case.
https://claude.ai/code/session_01QKx2yv6cnjKgJAeHkU6JEG