fix: remove HOP columns from embedded schema (crystallizes, quality_score)#2837
Merged
maphew merged 1 commit intosteveyegge:mainfrom Mar 26, 2026
Conversation
…core) Migration 012 drops crystallizes and quality_score from issues and wisps tables, but the embedded Dolt schema files still define them. This creates a schema mismatch: fresh embedded installations get columns that the migration system intends to remove, and no Go code references either column. Remove both columns from 0001_create_issues.up.sql and 0020_create_wisps.up.sql to align embedded schema with the migration path. Fixes steveyegge#2817 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Small surgical fix with clean CI, thanks @outdoorsea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crystallizesandquality_scorecolumns from embedded Dolt schema filesMigrateDropHOPColumns) already drops these columns for server Dolt, but the embedded schema files still define themChanges
0001_create_issues.up.sql: removedcrystallizes TINYINT(1)andquality_score DOUBLE0020_create_wisps.up.sql: sameTest plan
Fixes #2817
🤖 Generated with Claude Code