fix: use UTC_TIMESTAMP() for defer_until comparisons#2819
Merged
maphew merged 1 commit intosteveyegge:mainfrom Mar 26, 2026
Merged
fix: use UTC_TIMESTAMP() for defer_until comparisons#2819maphew merged 1 commit intosteveyegge:mainfrom
maphew merged 1 commit intosteveyegge:mainfrom
Conversation
Go stores defer_until as UTC via time.Time, but Dolt's NOW() returns the server's local time. On non-UTC machines (e.g., PDT = UTC-7), the comparison 'defer_until <= NOW()' produces wrong results — a past-deferred issue may not appear in bd ready because NOW() returns a local time hours behind the UTC-stored defer_until. Fix: Replace NOW() with UTC_TIMESTAMP() in all 4 defer_until SQL comparisons (queries.go lines 169/1005, schema.go ready_issues view). Bump schema version to 8 so the view gets recreated. Adds two unit tests: - TestGetReadyWork_PastDeferredIssueIsReady - TestGetReadyWork_FutureDeferredIssueExcluded
Collaborator
|
Thanks @toumorokoshi this UTC timestamp fix is a real correctness bug that affects anyone not on UTC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go stores defer_until as UTC via time.Time, but Dolt's NOW() returns the server's local time. On non-UTC machines (e.g., PDT = UTC-7), the comparison 'defer_until <= NOW()' produces wrong results — a past-deferred issue may not appear in bd ready because NOW() returns a local time hours behind the UTC-stored defer_until.
Fix: Replace NOW() with UTC_TIMESTAMP() in all 4 defer_until SQL comparisons (queries.go lines 169/1005, schema.go ready_issues view). Bump schema version to 8 so the view gets recreated.
Adds two unit tests: