fix: comparison of CPE versions for large numbers #285
+399
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed intermittent exceptions,
Comparison method violates its general contract!.As such, I had Amp take a look at the compareTo and equals of Cpe.java, and this is what it came up with:• Primary Bug (FIXED): compareVersions mixed Long numeric comparison with lexicographic fallback when numbers exceeded Long.MAX_VALUE, violating transitivity
• Fix: Use BigInteger for all numeric comparisons
• Locale Dependency (FIXED): compareAttribute used default locale for toLowerCase() which could cause non-deterministic behavior
• Fix: Use Locale.ROOT for consistent behavior across all environments
I'm not convinced this was the root cause of the exception - but it does improve the class a little. Note that the code changes in this PR are entirely AI-generated.